Limit Tabs에 대한 리뷰
Limit Tabs 제작자: RudyF
mos_basik 님의 리뷰
You have no idea how wide my smile was when I found this extension and started experimenting with it.
My workflow combines TreeStyleTabs, dozens of named virtual desktops, and Firefox's built in tab title searching ability. My tabs are an extension of my mind. But it's true! - I don't need 400+ tabs. The old ones just lose relevance after a while.
I configured a global limit of 200, waited for the extension to enforce it, and boom! my system's responsiveness jumped.
5 stars for what you have right now in v2.2.6 :)
I did run into a couple of issues, though, so I extracted your code and looked through it (pretty clean, thanks!) and I have a couple of comments:
1. I found a bug where the act of loading the preferences page causes the add-on to enter "current window limit" mode, regardless of whether it was configured to use "current window limit" or "global limit" mode until then. I think using a ?? rather than a || on line 141 of options.js fixes this.
2. The "Least Recently Used" strategy for removing a tab always removes tabs from the current window, regardless of whether the tab limit is enforced globally or per-window. This surprised me - I was expecting this strategy to remove the oldest tabs from all windows when the limit is being enforced globally. I admit both strategies are valid! My suggestion - split the current LRU strategy in two: "Least Recently Used (Current)" and "Least Recently Used (Global)".
3. I'm happy to see that the "last accessed" timestamp of a tab survives a browser restart! (I verified this!) If it did not, that would play hob with my setup. Just mentioning this here in case someone else was worried about it like I was.
I saw from another response that you don't have a repository anywhere, or I would have said all this in Issues or PRs or something.
I saw this is GPLv3 (thanks!) so I threw up a repo on GitHub with some changes. I'm not supposed to put links in reviews, but you can find it under user "mosbasik" and repo "limit-tabs". I've implemented the bugfix and LRU strategy split I mentioned.
My workflow combines TreeStyleTabs, dozens of named virtual desktops, and Firefox's built in tab title searching ability. My tabs are an extension of my mind. But it's true! - I don't need 400+ tabs. The old ones just lose relevance after a while.
I configured a global limit of 200, waited for the extension to enforce it, and boom! my system's responsiveness jumped.
5 stars for what you have right now in v2.2.6 :)
I did run into a couple of issues, though, so I extracted your code and looked through it (pretty clean, thanks!) and I have a couple of comments:
1. I found a bug where the act of loading the preferences page causes the add-on to enter "current window limit" mode, regardless of whether it was configured to use "current window limit" or "global limit" mode until then. I think using a ?? rather than a || on line 141 of options.js fixes this.
2. The "Least Recently Used" strategy for removing a tab always removes tabs from the current window, regardless of whether the tab limit is enforced globally or per-window. This surprised me - I was expecting this strategy to remove the oldest tabs from all windows when the limit is being enforced globally. I admit both strategies are valid! My suggestion - split the current LRU strategy in two: "Least Recently Used (Current)" and "Least Recently Used (Global)".
3. I'm happy to see that the "last accessed" timestamp of a tab survives a browser restart! (I verified this!) If it did not, that would play hob with my setup. Just mentioning this here in case someone else was worried about it like I was.
I saw from another response that you don't have a repository anywhere, or I would have said all this in Issues or PRs or something.
I saw this is GPLv3 (thanks!) so I threw up a repo on GitHub with some changes. I'm not supposed to put links in reviews, but you can find it under user "mosbasik" and repo "limit-tabs". I've implemented the bugfix and LRU strategy split I mentioned.
개발자 답글
3년 전에 게시됨Sorry for the delayed response... and the delayed fix. 2.2.8 should have fixed issues 1 and 2. Thanks to Peter Henry for getting in touch with me.
리뷰 85개
- 5점 만점에 5점TurtleF4st 님, 20일 전Super helpful! Many thanks for sharing. Be sure to winnow your open tabs below your target threshold before enabling, otherwise anything over the target will be zapped (and seemingly gone forever). Despite that initial hiccup, I love it. Helps me keep a relatively narrow focus on browsing and research activities instead of having innumerable pending queues that are better managed with alt methods.
- 5점 만점에 5점aquariummagnitude869 님, 일 년 전
- Can please make it so I can only open 1 tab?
Edit: I'm going hardcore on this "1 tab" thing, I'm trying to use my pc only for watching classes and when I have two tabs I have the option to open social media on the second one, please. This is one of my favourite tabs, and the option to make turning off more difficult (like timeblocks or a waiting time to turn off)
Edit:Thank you so much, I'll be waiting for the waiting time option, love your work. - 5점 만점에 5점Yuvi Panda 님, 2년 전First time I've ever reviewed an extension. Absolutely absolutely love it! Keeps me very grounded :) Thank you!
- 5점 만점에 4점Firefox 사용자 18348244 님, 2년 전Does exactly what it's meant to do! I do have two personal suggestions, however:
The language of the settings, I think, should be changed, as they're a bit confusing at first. For starters, the "maximum number of tabs" is actually the tab number at which the extension will begin limiting; that is, I have the limit set to 11, but I can only have 10 tabs open at once. I feel that this should be changed so that the number represents exactly how many tabs you can have open at once.
Here are the ways I, personally, might change the rest of the language:
* "Above limit per window [if unchecked, applies globally]" -> "Apply tab limits to individual windows (as opposed to browser-wide limits)"
* "When exceeded, remove tab:" -> "When tab limit is exceeded..."
* "Newest" -> "remove most recently opened tab"
* "Least recently used" -> "remove least recently used tab"
* "Left-most" -> "remove left-most tab"
* "Right-most" -> "remove right-most tab"
* "And play sound:" -> "Play this sound when I try to exceed my tab limit:"
* "No sound" -> "Don't play a sound when I try to exceed my tab limit"
These may seem pretty pedantic, but I was a bit confused when I first saw the options. Finally, there exists a work around that should probably be addressed: if you set the tab limit to only apply to each individual window, you can open a new window and then drag the tab into the original one, thus exceeding your tab limit from that window. In my opinion, a global tab limit should be the default.
Awesome work! - 5점 만점에 5점minecraft_cat 님, 2년 전I am autistic as well and find my self getting many tabs open without even realizing it. On my phone I had 500 open. My computer was 50. It slows it down alot. I downloaded this and it makes my computer and phone much faster since i downloaded this addon and the sound lets me know theres too many tabs open and i should delete some. Its really helpful. Thank you for making this.